Expose ReadBufCursor::remaining and ReadBufCursor::put_slice#3700
Merged
seanmonstar merged 1 commit intomasterfrom Jul 15, 2024
Merged
Expose ReadBufCursor::remaining and ReadBufCursor::put_slice#3700seanmonstar merged 1 commit intomasterfrom
seanmonstar merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
There is also #3515 that is similar, but more involved. |
seanmonstar
requested changes
Jul 12, 2024
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
Seems fair to add these :)
nox
force-pushed
the
readbufcursor-convenience
branch
from
c799237 to
327d902
Compare
Contributor
Author
|
@seanmonstar I addressed both comments. |
There is currently no way to write to ReadBufCursor without unsafe code, even though writing a slice to it like one would do to a Buf shouldn't require unsafe code.
nox
force-pushed
the
readbufcursor-convenience
branch
from
327d902 to
a64315b
Compare
seanmonstar
approved these changes
Jul 15, 2024
Contributor
Author
|
Can we release 1.5 to get this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no way to write to ReadBufCursor without unsafe code, even though writing a slice to it like one would do to a Buf shouldn't require unsafe code.